West Midlands | 25-ITP-Sept | Georgina Rogers | Sprint 1 | Sprint 1 Coursework #841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… calculation and improve test descriptions
zilinskyte
added
Needs Review
cjyuan
reviewed
Nov 21, 2025
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Groups/blob/general-review-feedback/Sprint-1/feedback.md
Doing so can help reviewers speed up the review process. Thanks.
cjyuan
added
Reviewed
zilinskyte
added
Needs Review
cjyuan
reviewed
Dec 5, 2025
|
|
||
| if (numbers.length === 0) return null; // Must have at least one number | ||
|
|
||
| const sorted = numbers.slice().sort((a, b) => a - b); |
Contributor
There was a problem hiding this comment.
.slice() also creates a new array.
Comment on lines
+2
to
+15
| if (!Array.isArray(elements) || elements.length === 0) { | ||
| return -Infinity; | ||
| } | ||
| let max = -Infinity; | ||
|
|
||
| for (const x of elements) { | ||
| if (typeof x === "number" && Number.isFinite(x)) { | ||
| if (x > max) max = x; | ||
| } | ||
| } | ||
|
|
||
| return max; | ||
| // removed .filter as this creates a new array so this avoids unnecessary clones | ||
|
|
cjyuan
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Functions and tests fixed, implemented, and refactored
Questions
.