West Midlands | ITP-Sep-25 | Ahmad Ehsas | sprint 1 | Data groups #804

ahmadehsas · 2025-10-28T12:33:37Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I have completed all mandatory tasks.

Questions

…l the tets.

… tests cases.

…rray and passed the tests of given arrays.

…en tests.

github-actions · 2025-10-28T12:33:50Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-28T12:34:11Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-28T12:34:32Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-28T12:34:40Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-28T12:34:40Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-28T12:34:41Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

A-O-Emmanuel · 2025-11-12T18:10:03Z

Sprint-1/fix/median.js

This is a really good attempt at the median function, good work!

github-actions · 2025-11-12T18:10:46Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-12T18:10:48Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

A-O-Emmanuel · 2025-11-12T18:23:26Z

Sprint-1/implement/dedupe.js

I agree with your logical flow here.

A-O-Emmanuel · 2025-11-12T18:24:27Z

Sprint-1/implement/dedupe.test.js

This also works, good work!

A-O-Emmanuel · 2025-11-12T18:27:19Z

Sprint-1/implement/max.js

This is another good attempt, but It should be -Infinity and not Infinity, good work!

A-O-Emmanuel · 2025-11-12T18:32:05Z

Sprint-1/implement/sum.js

This works too good one!

A-O-Emmanuel · 2025-11-12T18:39:43Z

Sprint-1/refactor/includes.js

This is another good implemenation, good work!

github-actions · 2025-11-12T18:40:30Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-12T18:40:31Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

A-O-Emmanuel · 2025-11-12T18:42:18Z

Also, you need to adjust your pull request to be in the expected format

github-actions · 2025-11-24T20:29:50Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (data groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2025-11-24T20:30:51Z

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

illicitonion · 2025-12-19T17:02:18Z

Sprint-1/implement/max.test.js

When I ran these tests they didn't pass - can you check them.

ahmadehsas added 5 commits July 28, 2025 15:16

Fixed the implementaton of the function CalculateMedian and passed al…

96e54cd

…l the tets.

Implemented the deduplicate function with given arrays and passed the…

d577680

… tests cases.

Implemented the function findMax and passed the tests for given arrays.

3ecbe9f

Implemented the function sum that sums the numerical elements of an a…

0467d03

…rray and passed the tests of given arrays.

Refactored the implementation of Includes function and passed the giv…

a9a5914

…en tests.

ahmadehsas added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 28, 2025

Merge branch 'CodeYourFuture:main' into data-groups/Sprint-1

f666df4

A-O-Emmanuel reviewed Nov 12, 2025

View reviewed changes

Sprint-1/fix/median.js

Copy link

A-O-Emmanuel Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really good attempt at the median function, good work!

ahmadehsas reacted with hooray emoji

A-O-Emmanuel added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 12, 2025

A-O-Emmanuel reviewed Nov 12, 2025

View reviewed changes

Sprint-1/implement/dedupe.js

Copy link

A-O-Emmanuel Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your logical flow here.

ahmadehsas reacted with hooray emoji

A-O-Emmanuel reviewed Nov 12, 2025

View reviewed changes

Sprint-1/implement/dedupe.test.js

Copy link

A-O-Emmanuel Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also works, good work!

ahmadehsas reacted with hooray emoji

A-O-Emmanuel reviewed Nov 12, 2025

View reviewed changes

Sprint-1/implement/sum.js

Copy link

A-O-Emmanuel Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works too good one!

ahmadehsas reacted with hooray emoji

A-O-Emmanuel reviewed Nov 12, 2025

View reviewed changes

Sprint-1/refactor/includes.js

Copy link

A-O-Emmanuel Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is another good implemenation, good work!

ahmadehsas reacted with hooray emoji

A-O-Emmanuel added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Nov 12, 2025

modified the infinity to -infinity.

b51939c

ahmadehsas added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 24, 2025

illicitonion reviewed Dec 19, 2025

View reviewed changes

Sprint-1/implement/max.test.js

Copy link

Member

illicitonion Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I ran these tests they didn't pass - can you check them.

illicitonion added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 19, 2025

Uh oh!

West Midlands | ITP-Sep-25 | Ahmad Ehsas | sprint 1 | Data groups #804

Are you sure you want to change the base?

West Midlands | ITP-Sep-25 | Ahmad Ehsas | sprint 1 | Data groups #804

Uh oh!

Conversation

ahmadehsas commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

A-O-Emmanuel Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 12, 2025

Uh oh!

github-actions bot commented Nov 12, 2025

Uh oh!

A-O-Emmanuel Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

A-O-Emmanuel Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

A-O-Emmanuel Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

A-O-Emmanuel Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

A-O-Emmanuel Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 12, 2025

Uh oh!

github-actions bot commented Nov 12, 2025

Uh oh!

A-O-Emmanuel commented Nov 12, 2025

Uh oh!

github-actions bot commented Nov 24, 2025

Uh oh!

github-actions bot commented Nov 24, 2025

Uh oh!

illicitonion Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ahmadehsas commented Oct 28, 2025 •

edited

Loading