Manchester | ITP May 2025 | Chukwuemeke Ajuebor | Sprint 3 | Alarm clock app #778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AjueborChukwuemeke
added
the
Needs Review
LonMcGregor
reviewed
Aug 18, 2025
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work on this task so far. I do have one thing to consider - what happens if a user starts a new timer while the current alarm is playing? Can you think of a way to improve the user experience here?
LonMcGregor
added
Reviewed
|
This PR needs approval and we cannot read the Brag Diary - can you change the settings, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
In this PR, I learnt about creating events and how javascript interacts with the webpage in the DOM
I understood better the key differences global variables and function declarations can make in script of code.
I also learned about function such as setInterval and clearInterval and their relevance to building setting types of projects.
Questions
No questions for now.