-
-
Notifications
You must be signed in to change notification settings - Fork 207
WM | 25-ITP-May | Nahom Mesfin | Sprint 3 | alarm clock #776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WM | 25-ITP-May | Nahom Mesfin | Sprint 3 | alarm clock #776
Conversation
LonMcGregor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work on this task, I have found one edge case for you to consider: What happens when you try to start a new timer when the old one has finished and is still playing an alarm? Can you think of any way to improve that userexperience?
I have added |
|
What about the alarm itself? What happens if you start a new alarm while the old sound is still playing? |
I see the issue now, if a new alarm is set, the old sound just keeps playing. I fixed this issue by pausing the alarm
|
|
Thank you for the feedbacks and suggestions you have given me to improve my work throughout this sprint. |
|
Great work - you are done with this PR and sprint now |
Learners, PR Template
Self checklist
Changelist
Alarm Clock:
Implemented countdown functionality that updates the title with time remaining.
Added alarm sound playback when the timer reaches zero.
Created a stop button to stop the sound of the alarm.
Updated index.html title to "Alarm clock app