Skip to content

London | 25-ITP-May |Surafel Abdissa | Sprint 3 | Reading-list #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SuWebOnes wants to merge 5 commits into from
Closed

London | 25-ITP-May |Surafel Abdissa | Sprint 3 | Reading-list #720

SuWebOnes wants to merge 5 commits into from

Conversation

@SuWebOnes
Copy link

@SuWebOnes SuWebOnes commented Jul 29, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

ClaudioRicci
ClaudioRicci approved these changes Jul 29, 2025
View reviewed changes
Copy link

@ClaudioRicci ClaudioRicci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is just substituting placeholder text in the <title> for correct copy and formatting is correct, this can be approved

@SuWebOnes SuWebOnes changed the title London | 25-ITP-May |Surafel Abdissa | Sprint 3 |eading-list London | 25-ITP-May |Surafel Abdissa | Sprint 3 |Reading-list Jul 30, 2025
@SuWebOnes SuWebOnes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 30, 2025
@SuWebOnes SuWebOnes changed the title London | 25-ITP-May |Surafel Abdissa | Sprint 3 |Reading-list London | 25-ITP-May |Surafel Abdissa | Sprint 3 | Reading-list Jul 30, 2025
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Aug 19, 2025
LonMcGregor
LonMcGregor reviewed Aug 19, 2025
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work - this PR and sprint task is complete

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

+1 more reviewer

@ClaudioRicci ClaudioRicci ClaudioRicci approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SuWebOnes @LonMcGregor @ClaudioRicci @illicitonion