Sheffield | May-2025 | Waleed- Salih-Taha | Sprint 2 | Data Group #672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed extra space.
…ty object with test one
Bluejay600
added
Needs Review
cjyuan
reviewed
Aug 7, 2025
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
-
The file
Sprint-2/implement/querystring.jswas not updated. -
These two files are still not properly reverted:
Sprint-3/quote-generator/index.htmlSprint-2/interpret/test.js
Note: You can view which files have been modified when compared to CYF's main on
https://github.com/CodeYourFuture/Module-Data-Groups/pull/672/files
All other changes look good.
cjyuan
added
Reviewed
Bluejay600
added
Needs Review
cjyuan
reviewed
Aug 12, 2025
Sprint-2/implement/querystring.js
Outdated
| queryParams[key] = value; | ||
| for (const pair of pairs) { | ||
| const [rawKey, rawValue] = pair.split("="); | ||
| const key = rawKey !== undefined ? decodeURIComponent(rawKey) : ""; |
Contributor
There was a problem hiding this comment.
Could rawKey ever be undefined?
| const result = {}; | ||
| for (const [country, currency] of pairs) { | ||
| result[country] = currency; | ||
| if (!Array.isArray(pairs)) { |
cjyuan
added
Reviewed
Bluejay600
added
Needs Review
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s |
1 similar comment
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s |
Bluejay600
changed the title
cjyuan
reviewed
Aug 17, 2025
| const key = pair.slice(0, idx); | ||
| const value = pair.slice(idx + 1); | ||
|
|
||
| if (key === "equation" || key === "formula" || key === "expression" || value.includes('=')) { |
Contributor
There was a problem hiding this comment.
Why don't you apply decodeURIComponent() to a value when it includes a "=" or when the key is one of those three values?
| queryParams[key] = value; | ||
| } else { | ||
| try { | ||
| queryParams[key] = decodeURIComponent(value.replace(/\+/g, ' ')); |
Contributor
There was a problem hiding this comment.
key can also be URI-encoded in practice.
cjyuan
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
this PR gives a short set of requirements about a function. and You will need to implement, interpret and and sometimes fix a function based off this set of requirements
Questions
Ask any questions you have for your reviewer.