Skip to content

ZA| Innocent Niwatwine |Data groups sprint 3- Alarm clock #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
InnocentNiwatwine wants to merge 6 commits into from
Closed

ZA| Innocent Niwatwine |Data groups sprint 3- Alarm clock #628

InnocentNiwatwine wants to merge 6 commits into from

Conversation

@InnocentNiwatwine
Copy link

@InnocentNiwatwine InnocentNiwatwine commented Jul 16, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@InnocentNiwatwine InnocentNiwatwine changed the title Alarm clock ZA| Innocent Niwatwine |Data groups sprint 3- Alarm clock Jul 16, 2025
@InnocentNiwatwine InnocentNiwatwine added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 21, 2025
@Waldo-Strydom
Copy link

Waldo-Strydom commented Jul 26, 2025

Please add your HTML file.

@Waldo-Strydom Waldo-Strydom added 👀 Review Git and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 26, 2025
@InnocentNiwatwine InnocentNiwatwine added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 27, 2025
@InnocentNiwatwine
Copy link
Author

InnocentNiwatwine commented Jul 27, 2025

Please add your HTML file.

Thank you Mr Waldo, i did add the html

Waldo-Strydom
Waldo-Strydom reviewed Jul 28, 2025
View reviewed changes
@InnocentNiwatwine
Copy link
Author

InnocentNiwatwine commented Jul 31, 2025

Please add your HTML file.

Thank you Mr Walda could you please review because i added the html,

@Waldo-Strydom Waldo-Strydom added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 2, 2025
@InnocentNiwatwine
Copy link
Author

InnocentNiwatwine commented Aug 8, 2025

Thank you Mr Walda, i have redone the code and have tried to test it and it should not have a problem

@InnocentNiwatwine InnocentNiwatwine added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 8, 2025
Waldo-Strydom
Waldo-Strydom reviewed Aug 10, 2025
View reviewed changes
Sprint-3/alarmclock/alarmclock.js
}

function setup() {
document.getElementById("set").addEventListener("click", () => {
Copy link

@Waldo-Strydom Waldo-Strydom Aug 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the code connected to the buttons back in. Currently they are not working.

Copy link
Author

@InnocentNiwatwine InnocentNiwatwine Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you kindly review so that i can submit

@Waldo-Strydom Waldo-Strydom removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 10, 2025
@InnocentNiwatwine InnocentNiwatwine added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 12, 2025
@InnocentNiwatwine InnocentNiwatwine mentioned this pull request Aug 12, 2025
Open
Waldo-Strydom
Waldo-Strydom reviewed Aug 13, 2025
View reviewed changes
Sprint-3/alarmclock/alarmclock.js Outdated
@@ -1,25 +1,60 @@
function setAlarm() {}
let countdown;
let ispaused = false;
Copy link

@Waldo-Strydom Waldo-Strydom Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image There is an error here, Please check your spelling.

Copy link

@Waldo-Strydom Waldo-Strydom Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else is fine. Please just fix this one line.

Copy link
Author

@InnocentNiwatwine InnocentNiwatwine Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you sir,Kindly review

@Waldo-Strydom Waldo-Strydom removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 13, 2025
@InnocentNiwatwine InnocentNiwatwine added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 14, 2025
@github-actions
Copy link

github-actions bot commented Aug 14, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

@Waldo-Strydom
Copy link

Waldo-Strydom commented Aug 16, 2025

Well done

@Waldo-Strydom Waldo-Strydom removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 16, 2025
@Waldo-Strydom Waldo-Strydom added the Complete Volunteer to add when work is complete and all review comments have been addressed. label Aug 16, 2025
@github-actions
Copy link

github-actions bot commented Aug 16, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 16, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Waldo-Strydom Waldo-Strydom Waldo-Strydom left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@InnocentNiwatwine @Waldo-Strydom @illicitonion