Skip to content

Conversation

@Konvaly
Copy link

@Konvaly Konvaly commented Dec 16, 2025

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

PR: Fix bugs and improve adding books

What was done:

  • Fixed errors that stopped books from showing on page load

  • Fixed issues when adding a new book

  • Corrected author and read status values

  • Fixed the delete button

  • Cleared the form after a book is added

  • Prevented adding the same book twice

Result: the app now works as expected and is easier to use when adding books.

@Konvaly Konvaly added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 16, 2025
@cjyuan cjyuan deleted the branch CodeYourFuture:book-library December 17, 2025 13:10
@cjyuan cjyuan closed this Dec 17, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Dec 17, 2025

You opened this PR against a wrong branch. By default, instead of main, a branch with the same name is selected.

Can you create another PR, and make sure you open your PR against CYF's main branch?

After you have created a new PR, can you check if any of this general feedback can help you further improve your code?
https://github.com/cjyuan/Module-Data-Flows/blob/book-library-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants