Skip to content

Sheffield | 25-ITP-Sep | Jak Rhodes-Smith | Sprint 2 | Book Library #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jakr-s wants to merge 16 commits into from
Closed

Sheffield | 25-ITP-Sep | Jak Rhodes-Smith | Sprint 2 | Book Library #351

jakr-s wants to merge 16 commits into from

Conversation

@jakr-s
Copy link

@jakr-s jakr-s commented Dec 11, 2025

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Debugged the app

@jakr-s jakr-s added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 11, 2025
cjyuan
cjyuan reviewed Dec 11, 2025
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if any of this general feedback can help you further improve your code?
https://github.com/cjyuan/Module-Data-Flows/blob/book-library-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 11, 2025
@jakr-s jakr-s force-pushed the feature/book-library branch from 494bc23 to 7dc7f7a Compare December 12, 2025 15:18
@jakr-s jakr-s added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Dec 18, 2025
@jakr-s
Copy link
Author

jakr-s commented Dec 18, 2025

Can you check if any of this general feedback can help you further improve your code? https://github.com/cjyuan/Module-Data-Flows/blob/book-library-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

I've altered the code using this document as reference

cjyuan
cjyuan reviewed Dec 18, 2025
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Well done!

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 18, 2025
@jakr-s jakr-s mentioned this pull request Dec 19, 2025
Closed
@jakr-s jakr-s closed this Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jakr-s @cjyuan