-
-
Notifications
You must be signed in to change notification settings - Fork 161
ZA | 25-ITP-May | Malusi Skunyana | Sprint 1 | Destructuring #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Data Flows) doesn't match expected format (example: 'Sprint 2', without quotes) |
1 similar comment
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Data Flows) doesn't match expected format (example: 'Sprint 2', without quotes) |
|
Hi Malusi, Good work on this! All the exercises look good, with only some small comments to add. Exercise 3:
Also, as the github bot alert shows, the PR title needs to be corrected :) |
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s |
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s |
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Sprint-1) doesn't match expected format (example: 'Sprint 2', without quotes) |
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s |
|
Fixed PR title. |
…act formatting for receipt output
|
Thank you for great feedback! I have updated Exercise 3 to ensure the column widths and padding exactly match the expected result. The implementation now calculates column widths dynamically based on the longest values for quantity, item name, and total, so it remains properly aligned even if quantities, item names, or prices change significantly in the future. |
|
Nice one! Good work 👍 |
Learners, PR Template
Self checklist
Changelist
Refactor exercises to use object destructuring
Exercise 1: Updated introduceYourself to destructure personOne in the function parameter.
Exercise 2:
Exercise 3: Print takeout receipt with item totals and overall total, using destructuring for order items and formatting output to match expected results.
All exercises now leverage object destructuring for concise, readable code.
Questions
Ask any questions you have for your reviewer.