Skip to content

Conversation

@marcin-ptaszynski
Copy link
Contributor

@marcin-ptaszynski marcin-ptaszynski commented Sep 28, 2025

Summary

Support for serializing Tuple Structs in the same way as Tuples.

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided so that we can include it in CHANGELOG later
  • For significant changes, documentation in README and https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@marcin-ptaszynski marcin-ptaszynski force-pushed the feat-serialize-tuple-struct branch 2 times, most recently from 623fa53 to 204210e Compare September 28, 2025 11:58
@slvrtrn slvrtrn requested a review from abonander September 29, 2025 21:02
Copilot AI review requested due to automatic review settings January 9, 2026 19:26
@abonander abonander force-pushed the feat-serialize-tuple-struct branch from 204210e to 5d3c663 Compare January 9, 2026 19:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for serializing tuple structs in the SQL serializer by treating them the same way as tuples, wrapping their fields in parentheses and separating them with commas.

Changes:

  • Updated SqlSerializer to use SqlListSerializer for tuple structs instead of Impossible
  • Implemented SerializeTupleStruct trait for SqlListSerializer
  • Added test coverage for tuple struct serialization and removed the old test that expected tuple structs to error

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant