Skip to content

Fix compilation errors in key recovery and split modules #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ChronoCoders wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix compilation errors in key recovery and split modules #4

ChronoCoders wants to merge 1 commit into from

Conversation

@ChronoCoders
Copy link
Owner

@ChronoCoders ChronoCoders commented Nov 16, 2025

  • Add save_private_key function to crypto/rsa module
  • Move shamir.rs to correct module location (src/shamir.rs)
  • Fix Share struct field references (index -> id, remove key_id)
  • Add proper trait imports (DecodePrivateKey, EncodePrivateKey)
  • Fix HermesError::DecryptionFailed usage as unit variant
  • Handle pkcs8::Error conversion properly in key_split

@claude
Fix compilation errors in key recovery and split modules
f521b6a 
- Add save_private_key function to crypto/rsa module
- Move shamir.rs to correct module location (src/shamir.rs)
- Fix Share struct field references (index -> id, remove key_id)
- Add proper trait imports (DecodePrivateKey, EncodePrivateKey)
- Fix HermesError::DecryptionFailed usage as unit variant
- Handle pkcs8::Error conversion properly in key_split
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ChronoCoders @claude