Skip to content

Fix devcontainer for website development #8967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CronKz wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −1
Open

Fix devcontainer for website development #8967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab24c12
Fix: Add libnss3 - used by puppeteer / gatsby
CronKz Dec 3, 2025
81bd2a4
Fix: Use host network to forward ports
CronKz Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,6 @@
"moby": "true"
}
},
"runArgs": ["--network=host"],
Copy link
Member

@michaelstaib michaelstaib Dec 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be needed as devcontainers have port forwarding builtin.

Copy link
Collaborator

@glen-84 glen-84 Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem to work for the website.

Copy link
Contributor Author

@CronKz CronKz Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ports are forwared automatically, regardless of this setting, but connection to the website fails (endless loading) without this option.

Also removing the --host 0.0.0.0 option here does also not resolve the underlying issue of not reaching the website without "runArgs": ["--network=host"],:

graphql-platform/website/package.json

Line 17 in 2affc65

"develop": "gatsby develop --verbose --host 0.0.0.0",

In that context, using "runArgs": ["--network=host"], enables you to access the website over your local network ip, to debug on actual phones instead of emulated ones.

Copy link
Member

@michaelstaib michaelstaib Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does disable Docker's network isolation, which is a minor security consideration in a dev environment. So I am not inclined to do that and rather figure out why port forwarding is a problem.

"postCreateCommand": "./init.sh"
}
3 changes: 2 additions & 1 deletion .devcontainer/dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ RUN apt-get update && apt-get install -y \
gnupg2 \
lsb-release \
software-properties-common \
openssh-server
openssh-server \
libnss3

# Configure SSH server
RUN mkdir /var/run/sshd \
Expand Down