Skip to content

Conversation

@hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Dec 15, 2025

Summary of changes

Changes introduced in this pull request:

  • use only dev profile in CI to better utilize sccache build cache

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

  • Chores
    • Removed "quick" build profile and associated install targets, simplifying build options.
    • CI workflows updated to use the standard installation method instead of quick variants.
    • Test-release execution switched to the standard release profile.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 15, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Removed the "quick" cargo profile and all Makefile targets that referenced it; workflows were updated to call make install-slim and the test-release Makefile target now uses the release cargo profile instead of quick.

Changes

Cohort / File(s) Change Summary
Build profile removal
Cargo.toml
Removed the [profile.quick] block (opt-level = 1, lto = "off").
Makefile target cleanup
Makefile
Removed install-quick, install-slim-quick, install-minimum-quick targets; test-release changed to use --release (release profile) instead of quick.
Workflow updates
.github/workflows/butterflynet.yml, .github/workflows/forest.yml
Replaced make install-slim-quick with make install-slim in build/install steps.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Homogeneous configuration and Makefile target removals.
  • Areas to spot-check:
    • Cargo.toml to confirm no other references to quick remain.
    • Makefile for any targets or scripts still invoking quick variants.
    • Workflow YAMLs to ensure no remaining references to removed targets.

Suggested reviewers

  • akaladarshi
  • LesnyRumcajs

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(ci): deprecate quick cargo profile' accurately reflects the main changes: removing the quick profile from Cargo.toml and replacing all references to it in CI workflows and Makefile with alternative profiles.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Comment @coderabbitai help to get the list of available commands and usage tips.

@hanabi1224 hanabi1224 marked this pull request as ready for review December 16, 2025 16:29
@hanabi1224 hanabi1224 requested a review from a team as a code owner December 16, 2025 16:29
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and akaladarshi and removed request for a team December 16, 2025 16:29
@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.64%. Comparing base (08b2e2c) to head (3f42d98).

Additional details and impacted files

see 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08b2e2c...3f42d98. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hanabi1224 hanabi1224 mentioned this pull request Dec 17, 2025
4 tasks
akaladarshi
akaladarshi previously approved these changes Dec 17, 2025
@hanabi1224 hanabi1224 marked this pull request as draft December 17, 2025 12:09
Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, it slows down the local compilation so unless a viable alternative profile is provided, we shouldn't remove it.

@hanabi1224 hanabi1224 added the RPC requires calibnet RPC checks to run on CI label Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC requires calibnet RPC checks to run on CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants