Skip to content

fix: 修复third_party下没有目录的问题 #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Certseeds merged 1 commit into from
Oct 18, 2025
Merged

fix: 修复third_party下没有目录的问题 #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions third_party/rename.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
#!/usr/bin/env bash
set -euox pipefail
main() {
tar \
-xzvf third_party/catch2.tar.gz \
-C third_party/
Comment on lines +4 to +6
Copy link

Copilot AI Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tar command uses a relative path 'third_party/catch2.tar.gz' which will fail if the script is executed from a different working directory. Since the script already determines its own directory location on line 8, consider moving this tar extraction after the 'self_dir' assignment and using '$self_dir/catch2.tar.gz' instead to ensure the path is always correct regardless of where the script is invoked from.

Copilot uses AI. Check for mistakes.
# 定位到脚本所在目录（third_party）
local -r self_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
local -r tp_dir="$self_dir"
Expand Down