Skip to content

[SVCS-541] Allow WB to log download_file/zip #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AddisonSchiller wants to merge 2 commits into from
Closed

[SVCS-541] Allow WB to log download_file/zip #285

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef634a1
Allow WB to log download_file/zip
AddisonSchiller Oct 16, 2017
053e11c
Merge branch 'develop' into feature/svcs-541-callback-logs
cslzchen Dec 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions waterbutler/core/remote_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@
@utils.async_retry(retries=5, backoff=5)
async def log_to_callback(action, source=None, destination=None, start_time=None, errors=[]):
"""PUT a logging payload back to the callback given by the auth provider."""
if action in ('download_file', 'download_zip'):
logger.debug('Not logging for {} action'.format(action))
return

auth = getattr(destination, 'auth', source.auth)
log_payload = {
Expand All @@ -41,10 +38,6 @@ async def log_to_callback(action, source=None, destination=None, start_time=None
log_payload['metadata'] = source.serialize()
log_payload['provider'] = log_payload['metadata']['provider']

if action in ('download_file', 'download_zip'):
logger.info('Not logging for {} action'.format(action))
return

resp = await utils.send_signed_request('PUT', auth['callback_url'], log_payload)
resp_data = await resp.read()

Expand Down