Skip to content

[ENG-9985] Only the creator admin receives approval/deny email for registrations #11512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cslzchen merged 1 commit into from
Dec 29, 2025
+2 −2
Merged

[ENG-9985] Only the creator admin receives approval/deny email for registrations #11512

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions osf/models/sanctions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@
return
for contrib, node in group:
if contrib._id in self.approval_state:
return self.AUTHORIZER_NOTIFY_EMAIL_TYPE.instance.emit(
self.AUTHORIZER_NOTIFY_EMAIL_TYPE.instance.emit(
user=contrib,
subscribed_object=node,
event_context=self._email_template_context(
Expand All @@ -422,7 +422,7 @@
)
)
else:
return self.NON_AUTHORIZER_NOTIFY_EMAIL_TYPE.instance.emit(
self.NON_AUTHORIZER_NOTIFY_EMAIL_TYPE.instance.emit(
user=contrib,
subscribed_object=node,
event_context=self._email_template_context(contrib, node)
Expand Down Expand Up @@ -925,7 +925,7 @@

registration = self._get_registration()
if registration.is_spammy:
raise NodeStateError('Cannot approve a spammy registration')

Check failure on line 928 in osf/models/sanctions.py

View workflow job for this annotation

GitHub Actions / addons_and_admin 

Cannot approve a spammy registration

Check failure on line 928 in osf/models/sanctions.py

View workflow job for this annotation

GitHub Actions / addons_and_admin 

Cannot approve a spammy registration

super()._on_complete(event_data)
self.save()
Expand Down