-
Notifications
You must be signed in to change notification settings - Fork 354
[ENG-7812] Notification Refactor Phase 2 - Project PR #11498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
--------- Co-authored-by: John Tordoff <Johnetordoff@users.noreply.github.com> Co-authored-by: Ostap Zherebetskyi <ozherebetskyi@exoft.net> Co-authored-by: Bohdan Odintsov <bodintsov@exoft.net> Co-authored-by: John Tordoff <>
* Fix moderator digest * Fix unit tests
…ion (#11324) * Fix issue with user confirmation/merger creating subscription * Add docstrings
* Add No Login to notification template and add to tests
…tion-refactor-p2-s * Conflicts have not been resolved in this merge since we want to track how we fixed the conflicts due to complexity * api/nodes/serializers.py * osf/models/user.py * tests/test_auth.py * tests/test_webtests.py * website/templates/node_request_institutional_access_request.html.mako
…plate-with-naming [ENG-8988] Fix/notification contrib template with naming
[ENG-8997] Turn on script tests
[ENG-8996] Fix moderator added template
[ENG-9005] Fix/update v2 subscriptions
…tests [ENG-9603] Fix Reset Password Tests
…om/centerforopenscience/osf.io into fix-test-add-contributors-notifications
…-notifications [ENG-9600][ENG-9606] Notification refactor fix contributor adding issues
…om/centerforopenscience/osf.io into fix-institutional-request-templates
…-templates [ENG-9605] Fix institutional node request updates template
…ands [ENG-9969] revert management commands removal
[ENG-9977] Update defaults for no login email config
…cation_types [ENG-9970] Disable `post_migrate` that populates notification types and if possible make it a waffle switch/flag.
Ostap-Zherebetskyi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐
…gout [ENG-9983] Adding email confirmation link missing logout param
…r_notifications [ENG-9987] Branded provider notifications
…Sanction_ask [ENG-9985] Only the creator admin receives approval/deny email for registrations
…cation_types [ENG-9970] Check for the POPULATE_NOTIFICATION_TYPES switch only during the post-migration process
…ations [ENG-9997] update legacy notification migration logic
…n_verification [ENG-9991] Script for CE to verify migrated data after deployment
cslzchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final pass done with only minor issues ⭐
…ibutors [ENG-9993] Contributors fail to receive emails for being added as contributors to draft registrations if they are existing contributors on the project that the draft is created from.
Ostap-Zherebetskyi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎆
Purpose
Notification Refactor Phase 2
Changes
See project breakdown, JIRA tickets and individual PRs.
QA Notes
See QA & UAT testing plan
Documentation
Readme updated
Side Effects
N/A
Ticket
https://openscience.atlassian.net/browse/ENG-7812
https://openscience.atlassian.net/browse/ENG-10005