Skip to content

Conversation

@Vlad0n20
Copy link
Contributor

Purpose

Changes

QA Notes

Please make verification statements inspired by your code and what your code touches.

  • Verify
  • Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

https://openscience.atlassian.net/browse/ENG-8491?atlOrigin=eyJpIjoiNDVmYWQ5ODk0OTJlNGE0Y2FjMDI4ZjNiYWI4NTNmNmEiLCJwIjoiaiJ9

Copy link
Contributor

@ihorsokhanexoft ihorsokhanexoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@bodintsov
Copy link
Contributor

Looks great!

@Vlad0n20 Vlad0n20 changed the base branch from feature/pbs-25-21 to feature/pbs-25-25 December 24, 2025 13:22
Copy link
Collaborator

@adlius adlius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question

Comment on lines +24 to +25
class AddSystemTagForm(forms.Form):
system_tag_to_add = forms.CharField(label='system_tag_to_add', min_length=1, max_length=1024, required=True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this? Does this belong to this ticket?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't add that. In git blame, I see that it was added on 12/02, and I created this PR last week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants