-
Notifications
You must be signed in to change notification settings - Fork 354
[ENG-8491] Feature/eng 8491 #11406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/pbs-25-25
Are you sure you want to change the base?
[ENG-8491] Feature/eng 8491 #11406
Conversation
ihorsokhanexoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done
|
Looks great! |
1b8c36d to
aa38bee
Compare
adlius
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question
| class AddSystemTagForm(forms.Form): | ||
| system_tag_to_add = forms.CharField(label='system_tag_to_add', min_length=1, max_length=1024, required=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this? Does this belong to this ticket?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't add that. In git blame, I see that it was added on 12/02, and I created this PR last week.
Purpose
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-8491?atlOrigin=eyJpIjoiNDVmYWQ5ODk0OTJlNGE0Y2FjMDI4ZjNiYWI4NTNmNmEiLCJwIjoiaiJ9