Fixed the overlapped texts in the largest font and display size #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I meet the same issue, I think it is a good solution！@yuhuitech 🌹 |
|
It seems that this issue is a11y. @yuhuitech |
Collaborator
|
Hi ! Thanks for this pull request ! I will have a look very soon... Sorry I didn't have time to work on Carnet these last months I guess, instead of modifying the size, the best would be to find a way to make the text go to the next line |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear developer:
Hello! I am the creator of issue #134, and I have fixed the overlapped texts in the largest font and display size. I would appreciate it if you could kindly revise my code and leave me some suggestions. Thank you so much for your precious time!
Here are screenshots after my modifications, as you can see that those overlapped texts are fully separated now :)