Houston mulligan feature #9050
Houston mulligan feature #9050
Conversation
| return game; | ||
|
|
||
| } else { | ||
| for (RegisteredPlayer rp : players) { |
There was a problem hiding this comment.
Why is this loop needed? Also, I don't like that we're using raw values in this function. It feels like it will cause problems with Vanguard cards that modify starting hand size.
There was a problem hiding this comment.
removed the troubling code from Match class
There was a problem hiding this comment.
Did you? It still seems like its here.
There was a problem hiding this comment.
no this is outdated code
There was a problem hiding this comment.
You keep resolving this, but this IS showing up in your PR.
There was a problem hiding this comment.
How can I resolve this? Do I need to take out ' if (selectedRule == MulliganDefs.MulliganRule.Houston)' on line 80 or is the for loop 'for (RegisteredPlayer rp : players) {' on line 82 problematic? I will fix it, but I just need your guidance on what is wrong still.
forge-game/src/main/java/forge/game/mulligan/HoustonMulligan.java
Outdated
Show resolved
Hide resolved
forge-game/src/main/java/forge/game/mulligan/HoustonMulligan.java
Outdated
Show resolved
Hide resolved
forge-game/src/main/java/forge/game/mulligan/HoustonMulligan.java
Outdated
Show resolved
Hide resolved
…g logic to afterMulligan.
…ion for getModifiedHandSize in MulliganDefs class.
…modified startingHandSize in HoustonMulligan. Refactored logic in Match class to accommodate the changes. Removed startingHandSize logic from MulliganDefs.
forge-game/src/main/java/forge/game/mulligan/HoustonMulligan.java
Outdated
Show resolved
Hide resolved
forge-game/src/main/java/forge/game/mulligan/HoustonMulligan.java
Outdated
Show resolved
Hide resolved
| return game; | ||
|
|
||
| } else { | ||
| for (RegisteredPlayer rp : players) { |
There was a problem hiding this comment.
Did you? It still seems like its here.
… mulligans and then corrects back to 7 when turns start.
…liganService.java class.
| (SpellAbility)null | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
@tehdiplomat I have to readd the logic: if (player != null) {player.setMaxHandSize(7);} here. I tried to remove, but the game allows the player to have more than 7 cards in hand without other natural modifiers like Reliquary Tower or Thought Vessel.
There was a problem hiding this comment.
Okay I have it fixed now in latest push.
| return game; | ||
|
|
||
| } else { | ||
| for (RegisteredPlayer rp : players) { |
There was a problem hiding this comment.
How can I resolve this? Do I need to take out ' if (selectedRule == MulliganDefs.MulliganRule.Houston)' on line 80 or is the for loop 'for (RegisteredPlayer rp : players) {' on line 82 problematic? I will fix it, but I just need your guidance on what is wrong still.
There was a problem hiding this comment.
@tehdiplomat I have removed the logic from Match.java. It has been relocated to MulliganService.java. Any feedback is much appreciated.
2 participants
Fixes #8868