Addition of Azure Resource Manager provider terraform configuration #704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
can we take out the provider from the name, so its just terraform/azurerm |
Author
|
No problem, folder name updated |
terraform/azurerm/variables.tf
Outdated
|
|
||
| variable "subnet_cidr_block" { | ||
| description = "CIDR for private subnet" | ||
| } |
Member
There was a problem hiding this comment.
probably want to have some defaults for location , vn_cidr_block and subnet_cidr_block
Contributor
|
@heywoodj can we change any names referring to slave to agent please |
added 15 commits
May 6, 2016 09:30
…into azure_rmprovider
terraform/azurerm/variables.tf
Outdated
| default = "mesosimages-container" | ||
| } | ||
|
|
||
| variable "atlas_artifact_master" { |
Member
There was a problem hiding this comment.
we're not using atlas anymore - we're using the latest CoreOS images looks like you pulled code from an out of date branch
added 2 commits
May 10, 2016 16:57
added 30 commits
May 16, 2016 16:40
…into azure_rmprovider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of Azure terraform configuration using the resource manager provider.