Skip to content

Conversation

@OrdiNeu
Copy link
Contributor

@OrdiNeu OrdiNeu commented Jan 6, 2026

Ticket(s)

Description

This removes all instances of procedures, diseases, etc that map to concept_id==0, which is No matching concept. The idea behind this is to hide anything that is ultimately irrelevant to the user, as these are mismapped samples.
This removes these two in two places:

  1. Discovery counts no longer return these values (.info.drug_type_count, for instance)
  2. Any results with e.g. procedures without a matching code will no longer include it.

For example, a response that used to return

                     {
                        "procedureCode":{
                           "id":"None:No matching concept",
                           "label":"No matching concept"
                        },
                        "ageAtProcedure":{
                           "iso8601duration":"P52Y"
                        },
                        "dateOfProcedure":"2000-06-10"
                     }

will now exclude it from the response

To test

There's quite a lot in the synthetic data, so you can load it up and see the removal:

curl candig.docker.internal:5080/candig-api/v1/beacon/persons -H "Content-Type: application/json" -H "Authorization: Bearer $TOKEN" -d '{"meta": {"apiVersion": "v2.0.0"}, "query": {"requestedGranularity": "record", "filters": [{ "id": "SNOMED:33821000087103" }]}}'

The response will no longer include anything with:

                        "procedureCode":{
                           "id":"None:No matching concept",
                           "label":"No matching concept"
                        }

Types of Change(s)

  • 🪲 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)

If breaking, Which other services does it affect?

  • authx
  • data-portal
  • ingest
  • clinical ETL
  • federation
  • htsget-app
  • katsu
  • CanDIG OPA
  • Query

Has it been tested for:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • Prettier linter doesn't return errors
  • Locally tested
    • using stable release
    • using develop branches
  • Dev server tested
  • Production tested when merging into stable/production branch

@OrdiNeu OrdiNeu requested review from SonQBChau and mshadbolt January 6, 2026 19:11
Copy link
Contributor

@mshadbolt mshadbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and confirmed that these don't show up anymore

Copy link
Contributor

@SonQBChau SonQBChau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OrdiNeu OrdiNeu merged commit f6ca4e3 into develop Jan 7, 2026
@OrdiNeu OrdiNeu deleted the feature/no-concept-zero branch January 7, 2026 17:35
@OrdiNeu OrdiNeu restored the feature/no-concept-zero branch January 7, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants