-
Notifications
You must be signed in to change notification settings - Fork 0
Add documentation about adding new algorithms #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
74b9a50 to
fb339d1
Compare
|
This will need overhauling now that I have opened #69 to provide Abstract Base Classes for the I'll aim to re-write this when I get some time, but @admg26 it would be good to have you cast and eye over #69 to check that you're happy with this approach. |
|
@jatkinson1000 I have looked at the refactored code and am generally happy with this. |
admg26
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good.
fb339d1 to
b28268f
Compare
sjavis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation looks good - I can't think of anything missing. I have a few suggestions for improving the clarity.
sjavis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. It all looks good to me.
203bf8c to
02c5c81
Compare
Closes #55
Adds basic documentation on:
This is intended to provide a starting point that can be added to as users go through the experience of adding algorithms.