Add output_dir parameter to tempest extremes #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjavis
force-pushed
the
te-output-dir
branch
from
486fdf3 to
bbccd57
Compare
jatkinson1000
approved these changes
Dec 18, 2025
Member
jatkinson1000
left a comment
jatkinson1000
left a comment
There was a problem hiding this comment.
Thanks @sjavis this seems sensible to me.
Two small suggestions/queries but am happy.
I'm not sure if there is a way to check that this "fixes" #101 but I'd perhaps ask @qntmCharles if this is clearer in terms of usage. If time to test-drive great, but if not it will have to wait for students.
sjavis
force-pushed
the
te-output-dir
branch
2 times, most recently
from
0fd80c9 to
499157b
Compare
jatkinson1000
force-pushed
the
te-output-dir
branch
from
2a77bca to
78ee702
Compare
Member
|
Rebased for autosquash of fixups and then merging as @sjavis is on leave. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
output_dirparameter to bothDetectNodesParametersandStitchNodesParameters. If it is unset for detect nodes it will use a temporary directory, if it is unset for stitch nodes it will use the detect nodes value. It will create the directory if it is missing before the relevant system call.The documentation is also updated to recommend using
output_dir.Closes #101