Skip to content

Conversation

@JFU-NAVA-PBC
Copy link
Contributor

@JFU-NAVA-PBC JFU-NAVA-PBC commented Dec 2, 2024

JIRA Ticket:
BB2-3508

Currently, our sample apps use the unmaintained create-react-app, which depends on the deprecated react-scripts lib. In order to fix these issues, we should remove these libraries and follow the steps to migrate to Vite from CRA.

What Does This PR Do?

Replace CRA (create-react-script) with Vite and perform refactor / version elevation etc as needed.

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

  • Exam the artifacts Added/Removed, artifacts (and dependencies) belong to CRA should be cleaned up
  • Exam package.json: make sure equivalent CLIs are not lost but mapped to new CLIs (Vite CLIs)
  • Check Docs (readmes at top level and client level) are consistent with the implementation

Validation

For briefness, refer to "Validation" section of BB2 Python Sample App PR 84, verify similar steps and user experiences.

Note, sample app selenium tests (docker compose based) still broken see BB2-3315

@JFU-NAVA-PBC JFU-NAVA-PBC merged commit 4157043 into master Dec 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants