-
Notifications
You must be signed in to change notification settings - Fork 22
[wip] Some refactorings #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
span multiple lines. Before, we would return the \n literals.
|
Thank you for refactoring the padding and this approach, being self-contained, is definitely cleaner. Also thank you for the style and doc comment cleanup. Do you use a style guide or equivalent of stylua? I tried to match the existing style as best I could, but it's a subjective guess sometimes. For |
|
Yea, no worries man :) It took me a bit of playing with to figure out the context thing, but in the end I think you solved the problem really nicely. Truth be told, the style stuff is mostly just whatever the lua-lsp autocorrects to. But I don't mind little things here-and-there, so no worries. It is pretty subjective at the end of the day. I'm leaning towards changing the function signature for the helper to always return a table, like in your version, even for single line nodes. But I'm not sure. It would be consistent with how an action can return a string for single line things, and a table of strings for multi line. I think I'll put off making that decision for now. |
No description provided.