Skip to content

fixed errors and warnings #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brtnfld merged 2 commits into from
Jan 5, 2026
Merged

fixed errors and warnings #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a3d4b0
fixed errors and warnings
brtnfld Dec 17, 2025
99bc78b
reverted commented out ex_tetra_4 figure
brtnfld Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,7 @@ build/
__pycache__/
*/__pycache__/
_build


#Ignore vscode AI rules
.github/instructions/codacy.instructions.md
2 changes: 1 addition & 1 deletion CGNS
Open in desktop
Submodule CGNS updated 38 files
+1 −1 .github/workflows/codespell.yml
+0 −3 src/Test_UserGuideCode/C_code/CMakeLists.txt
+0 −71 src/Test_UserGuideCode/C_code/read_flowvert_ho_unst.c
+0 −136 src/Test_UserGuideCode/C_code/write_flowcell_ho_unst.c
+0 −182 src/Test_UserGuideCode/C_code/write_grid_ho_unst.c
+2 −7 src/cg_ftoc.c
+1 −6 src/cg_hash_types.h.in
+15 −315 src/cgns_f.F90
+4 −128 src/cgns_header.h
+27 −748 src/cgns_internals.c
+248 −2,845 src/cgnslib.c
+5 −143 src/cgnslib.h
+20 −37 src/cgnstools/cgnsplot/cgnstcl.c
+4 −27 src/cgnstools/cgnsview/cgns.tcl
+12 −28 src/cgnstools/utilities/cgns_to_aflr3.c
+7 −10 src/cgnstools/utilities/cgns_to_fast.c
+11 −33 src/cgnstools/utilities/cgns_to_vtk.c
+2 −2 src/cgnstools/utilities/update_ngon.c
+1 −1 src/doxygen/CGNSNav.dox
+0 −1 src/examples/fortran/Test_mixed_elements/cgread.F90
+28 −170 src/pcgnslib.c
+2 −33 src/ptests/CMakeLists.txt
+0 −7 src/ptests/Makefile.in
+0 −330 src/ptests/para_high_order.c
+0 −482 src/ptests/test_high_order_parallel.c
+3 −33 src/tests/CMakeLists.txt
+0 −7 src/tests/Makefile.in
+0 −346 src/tests/test_3d_elements.c
+0 −473 src/tests/test_error_handling.c
+0 −263 src/tests/test_hexa_order2.c
+0 −696 src/tests/test_high_order.c
+0 −301 src/tests/test_high_order_hexa.c
+0 −293 src/tests/test_high_order_quad.c
+0 −373 src/tests/test_isoparametric.c
+0 −534 src/tests/test_modal_interpolation.c
+0 −477 src/tests/test_serendipity.c
+0 −560 src/tests/test_spacetime.c
+16 −505 src/tools/cgnscheck.c
1 change: 1 addition & 0 deletions source/current.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Resources
current/news
current/CPEX
current/download
current/building
current/examples
current/softwarelist
doc
Expand Down
2 changes: 1 addition & 1 deletion source/governance/meetings.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Minutes
**2025**
--------

The detailed minutes from our 2025 meetings are now available on the `CGNS GitHub Wiki page <https://github.com/CGNS/CGNS/wiki/2025`_ .
The detailed minutes from our 2025 meetings are now available on the `CGNS GitHub Wiki page <https://github.com/CGNS/CGNS/wiki/2025>`_ .

**2024**
--------
Expand Down
9 changes: 5 additions & 4 deletions source/standard/SIDS/boundary.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,13 +333,14 @@ If present, these three entities take precedence over all corresponding entities

The :sidsref:`UserDefinedData_t` data structure allows arbitrary user-defined data to be stored in :sidskey:`Descriptor_t` and :sidskey:`DataArray_t` children without the restrictions or implicit meanings imposed on these node types at other node locations.

.. c:function:: FUNCTION ListLength()
**FUNCTION ListLength()**

:return value: ``int``
:dependencies: :sidskey:`PointRange`, :sidskey:`PointList`
*Return value:* ``int``

*Dependencies:* :sidskey:`PointRange`, :sidskey:`PointList`

:sidskey:`BCDataSet_t` requires the structure function :sidskey:`ListLength`, which is used to specify the length of locally defined Dirichlet and Neumann data arrays when the grid location of these quantities differs from that of the BC patch definition. If :sidskey:`PointRange` is specified, then :sidskey:`ListLength` is obtained from the number of points (inclusive) between the beginning and ending indices of :sidskey:`PointRange`. If :sidskey:`PointList` is specified, then :sidskey:`ListLength` is the number of indices in the list of points. In this situation, :sidskey:`ListLength` becomes a user input along with the indices of the list :sidskey:`PointList`. By user we mean the application code that is generating the CGNS database.

If neither :sidskey:`PointRange` or :sidskey:`PointList` is specified in a particular :sidskey:`BCDataSet_t` substructure, :sidskey:`ListLength` must be passed into it to determine the length of BC data arrays.


Expand Down
16 changes: 9 additions & 7 deletions source/standard/SIDS/grid.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ The third and fourth examples are for an unstructured zone with 15 tetrahedral a
Example - TETRA_4 Element Types
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This example uses the simple three-element tetrahedral grid shown below.
This example uses a simple three-element tetrahedral grid.

.. figure:: ../../../images/sids/figs/ex_tetra.gif
:width: 400px
Expand Down Expand Up @@ -748,17 +748,19 @@ Although intended for edge or face-based solution data for unstructured grids, t

The :sidsref:`UserDefinedData_t` data structure allows arbitrary user-defined data to be stored in :sidskey:`Descriptor_t` and :sidskey:`DataArray_t` children without the restrictions or implicit meanings imposed on these node types at other node locations.

.. c:function:: FUNCTION ListLength()
**FUNCTION ListLength()**

:return value: ``int``
:dependencies: :sidskey:`PointRange`, :sidskey:`PointList`
*Return value:* ``int``

*Dependencies:* :sidskey:`PointRange`, :sidskey:`PointList`

:sidskey:`FlowSolution_t` requires the structure function :sidskey:`ListLength`, which is used to specify the number of entities (e.g. vertices) corresponding to a given :sidskey:`PointRange` or :sidskey:`PointList`. If :sidskey:`PointRange` is specified, then :sidskey:`ListLength` is obtained from the number of points (inclusive) between the beginning and ending indices of :sidskey:`PointRange`. If :sidskey:`PointList` is specified, then :sidskey:`ListLength` is the number of indices in the list of points. In this situation, :sidskey:`ListLength` becomes a user input along with the indices of the list :sidskey:`PointList`. By user we mean the application code that is generating the CGNS database.

.. c:function:: FUNCTION DataSize()
**FUNCTION DataSize()**

:return value: one-dimensional ``int`` array of length :sidskey:`IndexDimension`
:dependencies: :sidskey:`IndexDimension`, :sidskey:`VertexSize[]`, :sidskey:`CellSize[]`, :sidskey:`GridLocation`, :sidskey:`Rind`, :sidskey:`ListLength[]`
*Return value:* one-dimensional ``int`` array of length :sidskey:`IndexDimension`

*Dependencies:* :sidskey:`IndexDimension`, :sidskey:`VertexSize[]`, :sidskey:`CellSize[]`, :sidskey:`GridLocation`, :sidskey:`Rind`, :sidskey:`ListLength[]`

The function :sidskey:`DataSize[]` is the size of flow solution data arrays. If :sidskey:`Rind` is absent then :sidskey:`DataSize` represents only the core points; it will be the same as :sidskey:`VertexSize` or :sidskey:`CellSize` depending on :sidskey:`GridLocation`. The definition of the function :sidskey:`DataSize[]` is as follows:

Expand Down
14 changes: 8 additions & 6 deletions source/standard/SIDS/misc.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,19 +264,21 @@ If present, these two entities take precedence over all corresponding entities a

The :sidskey:`UserDefinedData_t` data structure allows arbitrary user-defined data to be stored in :sidskey:`Descriptor_t` and :sidskey:`DataArray_t` children without the restrictions or implicit meanings imposed on these node types at other node locations.

.. c:function:: FUNCTION ListLength()
**FUNCTION ListLength()**

:return value: ``int``
:dependencies: :sidskey:`PointList`, :sidskey:`PointRange[]`
*Return value:* ``int``

*Dependencies:* :sidskey:`PointList`, :sidskey:`PointRange[]`

:sidskey:`DiscreteData_t` requires the structure function :sidskey:`ListLength`, which is used to specify the number of entities (e.g. vertices) corresponding to a given :sidskey:`PointRange` or :sidskey:`PointList`. If :sidskey:`PointRange` is specified, then :sidskey:`ListLength` is obtained from the number of points (inclusive) between the beginning and ending indices of :sidskey:`PointRange`.
If :sidskey:`PointList` is specified, then :sidskey:`ListLength` is the number of indices in the list of points. In this situation, :sidskey:`ListLength` becomes a user input along with the indices of the list :sidskey:`PointList`.
By user we mean the application code that is generating the CGNS database.

.. c:function:: FUNCTION DataSize()
**FUNCTION DataSize()**

*Return value:* one-dimensional ``int`` array of length :sidskey:`IndexDimension`

:return value: one-dimensional ``int`` array of length :sidskey:`IndexDimension`
:dependencies: :sidskey:`IndexDimension`, :sidskey:`VertexSize[]`, :sidskey:`CellSize[]`, :sidskey:`GridLocation`, :sidskey:`Rind`, :sidskey:`ListLength[]`
*Dependencies:* :sidskey:`IndexDimension`, :sidskey:`VertexSize[]`, :sidskey:`CellSize[]`, :sidskey:`GridLocation`, :sidskey:`Rind`, :sidskey:`ListLength[]`

The function :sidskey:`DataSize[]` is the size of discrete-data arrays. It is identical to the function :sidskey:`DataSize[]` defined for :sidskey:`FlowSolution_t`.

Expand Down
7 changes: 4 additions & 3 deletions source/standard/SIDS/multizone.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,10 +757,11 @@ The grid points making up a hole within a zone may be specified by :sidskey:`Poi

The :sidsref:`UserDefinedData_t` data structure allows arbitrary user-defined data to be stored in :sidskey:`Descriptor_t` and :sidskey:`DataArray_t` children without the restrictions or implicit meanings imposed on these node types at other node locations.

.. c:function:: FUNCTION PointListSize()
**FUNCTION PointListSize()**

:return value: ``int``
:dependencies: :sidskey:`PointList`
*Return value:* ``int``

*Dependencies:* :sidskey:`PointList`

:sidskey:`OversetHoles_t` requires one structure function, :sidskey:`PointListSize`, to identify the length of the :sidskey:`PointList` array. :sidskey:`PointListSize` is a user input. (See the discussion on function :ref:`PointListSize <PointListSize_abut>`.)

Expand Down
7 changes: 4 additions & 3 deletions source/standard/SIDS/particles.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,10 +206,11 @@ The :sidsref:`UserDefinedData_t` data structure allows arbitrary user-defined da

.. _DataSizeParticle:

.. c:function:: FUNCTION DataSize()
**FUNCTION DataSize()**

:return value: ``int``
:dependencies: :sidskey:`PointRange`, :sidskey:`PointList`
*Return value:* ``int``

*Dependencies:* :sidskey:`PointRange`, :sidskey:`PointList`

:sidskey:`ParticleSolution_t` requires the structure function :sidskey:`DataSize`, which is used to specify the number of entities corresponding to a given :sidskey:`PointRange` or :sidskey:`PointList`. This will therefore be the size of the :sidskey:`ParticleSolution` data arrays. If :sidskey:`PointRange` is specified, then :sidskey:`DataSize` is obtained from the number of points (inclusive) between the beginning and ending indices of :sidskey:`PointRange`. If :sidskey:`PointList` is specified, then :sidskey:`DataSize` is the number of indices in the list of points. In this situation, :sidskey:`DataSize` becomes a user input along with the indices of the list :sidskey:`PointList`. By "user", we mean the application code that is generating the CGNS database.

Expand Down
7 changes: 4 additions & 3 deletions source/standard/SIDS/time.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,10 +329,11 @@ Point-by-point grid velocity may also lead to relative motion of grid zones, or
However, no attempt is made here to require that the :sidsref:`ZoneGridConnectivity_t` information be updated to be consistent with the new grid locations.
Whether the :sidskey:`ZoneGridConnectivity_t` information refers to the original connectivity (of :sidsref:`GridCoordinates`) or the latest connectivity (of the moved or deformed grid) is currently left up to the user.

.. c:function:: FUNCTION DataSize()
**FUNCTION DataSize()**

:return value: one-dimensional ``int`` array of length :sidskey:`IndexDimension`
:dependencies: :sidskey:`IndexDimension`, :sidskey:`VertexSize[]`, :sidskey:`CellSize[]`, :sidskey:`GridLocation`, :sidskey:`Rind`
*Return value:* one-dimensional ``int`` array of length :sidskey:`IndexDimension`

*Dependencies:* :sidskey:`IndexDimension`, :sidskey:`VertexSize[]`, :sidskey:`CellSize[]`, :sidskey:`GridLocation`, :sidskey:`Rind`

The function :sidskey:`DataSize[]` is the size of the DataArrays containing the grid velocity components. It is identical to the function :sidskey:`DataSize[]` defined for :sidsref:`FlowSolution_t`.

Expand Down
Loading