-
Notifications
You must be signed in to change notification settings - Fork 16
BruteForce Detector changes #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
petrmiculek
wants to merge
43
commits into
CESNET:master
Choose a base branch
from
petrmiculek:updates
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
b407f95
Minor readability changes
petrmiculek 8405d22
Minor readability changes
petrmiculek 3b5b7d8
Minor readability changes
petrmiculek 22b9cdf
Updated READMEs
petrmiculek 3b06fc7
Rework in progress
petrmiculek 38c115f
Changes I did not make
petrmiculek 49d3df5
Readability changes
petrmiculek 56f8898
Minor changes
petrmiculek 182a6f6
Refactoring
petrmiculek 716654b
More refactoring, signature flags now in record.h
petrmiculek 79f6c60
Bit more cleaning up
petrmiculek 51f5ed5
Aesthetic changes
petrmiculek 7018a3f
Aesthetic changes, host.cpp if conditions simplified
petrmiculek e56e806
Aesthetic changes - renaming
petrmiculek dad4092
Switched calculating target matched/total ratio, !review truncation err!
petrmiculek 7630306
Aesthetic changes
petrmiculek 24be9c8
Renamed HostTimeout, simplified keepTrackingHost of checkForAttack
petrmiculek 265fb34
Improvement on keepTrackingHost part of checkForAttack
petrmiculek a033913
Mostly aesthetic changes
petrmiculek 33e9de8
Removed unnecessary variables, merged checkForTimeout functions,
petrmiculek 3052468
Removed more unnecessary variables, reports don't show matched count
petrmiculek 443cac0
Renamed attack states
petrmiculek 521393a
Clarified portscans, minor changes
petrmiculek 647d4d9
Reverted part of 3052468
petrmiculek be3d553
Renamed attack states
petrmiculek 9c363c3
Clarified portscans, minor changes
petrmiculek cfaf279
Reverted deleting of some variables
petrmiculek c42c023
Revert "Reverted deleting of some variables"
petrmiculek 39d0ff4
fixed attack names after rebasing
petrmiculek afd1d53
reverted evaluation of portscan-matched
petrmiculek 8d6b581
Merge remote-tracking branch 'cesnet-fork/updates' into bruteforce-re…
petrmiculek f36326f
Minor changes
petrmiculek 63e9108
Fixed some config var names
petrmiculek 8fe3b5e
Simplified attack evaluation, % of matched flows separate for each proto
petrmiculek 0e281e0
Reformatting, var names changes, fixes to default config
petrmiculek dd11d1f
Reformatting, var names changes, fixes to default config
petrmiculek eb94af0
Merge remote-tracking branch 'cesnet-fork/updates' into bruteforce-re…
petrmiculek 48aec36
travis build fix
petrmiculek a81800e
travis build fix
petrmiculek fba0a08
Merge remote-tracking branch 'cesnet-fork/updates' into bruteforce-re…
petrmiculek 903676c
Adhering to c++03
petrmiculek fc9b09c
Revert "Changes I did not make"
petrmiculek 21a04cf
Revert "Changes I did not make"
petrmiculek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is great that this description was updated.
However, it still seems strange... even though the description is more accurate now, who is an attacker and who is under attack? We expected that
SRC_IPis always an attacker. When there is something on the "list of incoming attacker IPs" , isSRC_IPa victim for these IPs?I think the output of the module should describe who is an attacker and victim more clearly...