fix diffatac error & refactor jobby usage for ccbr_tools v0.4 #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed creation and use of the 'stats' folder - Moved all logging and metadata (e.g., runinfo.yaml, snakemake logs, jobby files) to the 'logs' folder - Updated comments and variable references accordingly - Deprecated create_runinfo as spooker handles it via ccbr_tools v0.4+
…all; Dropped 'logs/' prefix from snakemake log paths ... these are outside logs folder as previous versions
…q paths for samples.tsv ... used for testing
kelly-sovacool
requested changes
May 21, 2025
Member
There was a problem hiding this comment.
- In the future, please use the PR template rather than deleting it. I edited your PR comment to add it back in and format it accordingly. Ideally the person who opens the PR fills out the template as a way to communicate to the reviewer (or whoever else may see the PR). I also edited the PR title to be a little more descriptive.
- The docs need to be updated to reflect that
statsis consolidated underlogs - See my suggestion for the changelog
kelly-sovacool
changed the title
- Added dryrun_git_commit.txt and run_git_commit.txt to the output file list and table. - Documented snakemake.log.jobby and snakemake.log.jobby.short as additional log outputs. - Expanded description of logs folder to reflect storage of older runinfo.yaml and snakemake.stats files. - Removed obsolete stats folder reference.
kelly-sovacool
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Issues
PR Checklist
(
Strikethroughany points that are not applicable.)CHANGELOG.mdwith a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/