Fix for devices with prebuilt vendor #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file was missed when moving recovery resources, but the assertion path was changed, as a result non-Treble devices failed to build. Fixes: Ia4045bd67ffb3d899efa8d20dab4c4299b87ee5f Change-Id: Ib7822a9bd5b1a2ab7e762e9fb35dbb22291a3a76
Change-Id: I05c0155e6331bfeccd4ad545e003fa3fa3498044 Signed-off-by: SamarV-121 <samarvispute121@pm.me>
* Before this commit, the generated `dynamic_partitions_op_list` in FullOTA packages always tries to remove all partitions and recreate them upon flashing. This makes it impossible to have a system-only "FullOTA" because vendor partition(s) are always removed. * This commit detects if a build is vendor-less and disables every dynamic partition operation except `resize`, in order to keep the original content around after the flash. The change should not affect non-dynamic-partition or builds with vendor image included. Change-Id: I0cded7f3b2958f35103d73d19b7fb5f292f6c17f Signed-off-by: Jesse Chan <jc@lineageos.org> Signed-off-by: SamarV-121 <samarvispute121@pm.me>
…ices not building vendor The function `HasVendorParition()` was moved inside `HasTrebleEnabled()` in 9276cf0 It also has a different implementation now `HasPartition()` which was used by it earlier is still present, using the same implementation, so use that directly Fixes the following error Traceback (most recent call last): File "/home/akhil/eleven/out/host/linux-x86/bin/ota_from_target_files/internal/stdlib/runpy.py", line 174, in _run_module_as_main File "/home/akhil/eleven/out/host/linux-x86/bin/ota_from_target_files/internal/stdlib/runpy.py", line 72, in _run_code File "/home/akhil/eleven/out/host/linux-x86/bin/ota_from_target_files/__main__.py", line 12, in <module> File "/home/akhil/eleven/out/host/linux-x86/bin/ota_from_target_files/internal/stdlib/runpy.py", line 174, in _run_module_as_main File "/home/akhil/eleven/out/host/linux-x86/bin/ota_from_target_files/internal/stdlib/runpy.py", line 72, in _run_code File "/home/akhil/eleven/out/host/linux-x86/bin/ota_from_target_files/ota_from_target_files.py", line 2300, in <module> File "/home/akhil/eleven/out/host/linux-x86/bin/ota_from_target_files/ota_from_target_files.py", line 2279, in main File "/home/akhil/eleven/out/host/linux-x86/bin/ota_from_target_files/ota_from_target_files.py", line 2019, in GenerateNonAbOtaPackage File "/home/akhil/eleven/out/host/linux-x86/bin/ota_from_target_files/ota_from_target_files.py", line 855, in WriteFullOTAPackage NameError: global name 'HasVendorPartition' is not defined Change-Id: I9bd4ebc9d6b103cfd572bfd5eacd3f7a5b1a661c Signed-off-by: Akhil Narang <me@akhilnarang.dev> Signed-off-by: SamarV-121 <samarvispute121@pm.me>
i am tracking your forked repo for my cafex build but still getting same error at 99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error: https://www.toptal.com/developers/hastebin/alacaracej.apache
without those commit it failed to build at 99%