-
Notifications
You must be signed in to change notification settings - Fork 8
build-ci v3: Update Infra For spack v1
#654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Note: This will continue to run the |
SeanBryan51
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @CodeGat, these changes look good to me! Happy to approve once you are ready on your end. Just a small nitpick regarding the commented out options
09303dc to
142f86c
Compare
142f86c to
b98c12f
Compare
|
Note that we are seeing a similar error across packages using |
|
Ah, some new issues. GitHub-hosted runners only guarantee 14GB of free space, which is smaller than the new Will have to resolve this, first... |
References issue ACCESS-NRI/build-ci#231 and PR ACCESS-NRI/build-ci#253
References project Spack `0.22` to `1.0` Migration
Important
This PR is a major update to the infrastructure. See below for the prerequisites for this repository to be able to merge this PR.
Important
This major version change marks the end of major infrastructure updates for CI using
spack < 1.0. They will still get bug fixes and non-breaking features if required.If you want to deploy to instances of
spack < 1.0, you must usebuild-ci v2.If you want to deploy to instances of
spack >= 1.0, you must usebuild-ci v3.Background
We are looking to transition
build-citov3! This is due to a migration tospack v1.X, fromv0.X, which offers many bug fixes, features, and optimisations.One of these changes is the splitting of spacks core codebase from the builtin spack-packages repository, which means that we have another lever to tweak for our builds: the version of
spack,spack-config, ourspack-packagesand the (new!) builtinspack-packages.Since we want to leave open the possibility of forking the builtin
spack-packages, we have also decided to renameACCESS-NRI/spack-packagestoACCESS-NRI/access-spack-packages. See ACCESS-NRI/access-spack-packages#295 for more info.Therefore this is a major version update, as there are the following changes to the inputs (and analogous changes to the workflow outputs):
spack-packages-refinput, which defaulted tomain(in future,api-v1).access-spack-packages-refinput, which defaults to theapi-v2branch.builtin-spack-packages-refinput, which defaults to themainbranch.This means that:
container-image-version: :rocky-0.22-*, orspack-ref<releases/1.0, you must stay onv2due to the input changes.container-image-version: :rocky-1.*-*, orspack-ref>=releases/1.0, you must migrate tov3due to the input changes.It is possible to test across these versions of
spackif required, via a mix of workflow versions. Ask @CodeGat if you need this functionality.Features
The main new features include:
spack-packagesrepository, as well as our ownaccess-spack-packagesrepository. All of the bugfixes, features and optimisations added since0.22are available to us for future inclusion intobuild-ci.ci.yml: A special extra feature forCABLE-LSM! We can now combine the self- and GitHub-hosted versions of the workflow into one file, so now one just needs to doinputs.run-self-hosted:false!Prerequisites for Merging
build-cientrypoints tov3(this PR!)builtin-spack-packages-refis requiredaccess-spack-packages-refis appropriatespack v1overspack v0.22📚 Documentation preview 📚: https://cable--654.org.readthedocs.build/en/654/