Skip to content

Conversation

@muni-corn
Copy link
Contributor

fixes #57 .

this may be a naive implementation, but it seems to work. let me know your thoughts on it!

it's past midnight for me and i just wanted to submit this before bed

Copy link
Owner

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for contributing!

I wonder if this is expected when trashing files? Does that work with within the standard desktop environment?

Also, I wonder if it wouldn't be better to try to get this to work, so all the special cases are automatically handled.

@Byron Byron force-pushed the cross-device-trash branch from 4366819 to 18c1358 Compare October 24, 2025 02:34
@Byron
Copy link
Owner

Byron commented Oct 24, 2025

Thanks a lot.

The instruction-following of the AI that probably did this isn't quite there though, it doesn't seem to know let X = Y else { }; even when given the structure.

Besides that, I think it's probably better than before and I trust that you tested this manually.

muni-corn and others added 2 commits October 24, 2025 04:37
* disable perma-failing macOS tests
* some code refactoring
@Byron Byron force-pushed the cross-device-trash branch from 18c1358 to 1894bfe Compare October 24, 2025 02:37
@Byron Byron merged commit d0784e4 into Byron:master Oct 24, 2025
4 checks passed
@muni-corn muni-corn deleted the cross-device-trash branch October 27, 2025 15:34
@muni-corn
Copy link
Contributor Author

muni-corn commented Oct 27, 2025

LOL i did use AI to help implement this feature initially, but i was the one that did the edits and misunderstood what you wanted with the let-else 😭 i'm gradually using let-else where i can in my own code, i'm just used to if-else

i'm glad you could get it fixed!! i've been looking into a portal implementation as well and i'll see if i can get that in eventually 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trashing doesn't work across different devices (linux)

2 participants