Skip to content

Fmu names of functions in pcp plots #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tesshub wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fmu names of functions in pcp plots #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07d088d
🎨personalized function names in pcp
Tesshub Dec 8, 2025
2dc44d7
✅ tests pass
Tesshub Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion corrai/sampling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -964,7 +964,15 @@ def plot_pcp(
results = pd.DataFrame()
for config in indicators_configs:
col, func, *extra = config
results[f"{func}_{col}"] = self.get_aggregated_time_series(
if extra and isinstance(extra[0], str):
name = extra[0]
elif callable(func):
name = func.__name__
elif isinstance(func, str):
name = func
else:
raise TypeError(f"Invalid aggregation function: {func}")
results[f"{name}_{col}"] = self.get_aggregated_time_series(
col, func, reference_time_series=None if not extra else extra[0]
)
else:
Expand Down
9 changes: 9 additions & 0 deletions tests/test_sampling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,15 @@ def test_plot_pcp_in_sampler(self):
assert isinstance(fig, go.Figure)
assert len(fig.data) == 1

def last_val(x):
return x.iloc[-1]

fig2 = sampler.sample.plot_pcp([("res", last_val)])

dims2 = fig2.data[0]["dimensions"]
labels2 = [d["label"] for d in dims2]
assert "last_val_res" in labels2

def test_lhs_sampler(self):
# Dynamic
sampler = LHSSampler(
Expand Down