Skip to content

Conversation

@imgullu786
Copy link
Collaborator

@imgullu786 imgullu786 commented Jan 13, 2026

closes #121

Summary by CodeRabbit

  • New Features
    • Added a Card Image attachment for Buzz Event to support visual cards.
    • Added a Meta Image attachment for Buzz Event for metadata previews.
    • Added tax configuration for Buzz Event: enable/disable tax, set tax label, and set tax percentage (defaults to GST at 18% when enabled).

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 13, 2026

📝 Walkthrough

Walkthrough

Added a new card_image Attach Image field and tax-related fields (apply_tax, tax_label, tax_percentage) to the Buzz Event doctype; updates applied in both the JSON schema and Python document class, with defaults applied when tax is enabled.

Changes

Cohort / File(s) Change Summary
Buzz Event Doctype files
buzz/events/doctype/buzz_event/buzz_event.json, buzz/events/doctype/buzz_event/buzz_event.py
Added card_image (Attach Image) to schema and class; added tax fields apply_tax (Check), tax_label (Data), tax_percentage (Percent); adjusted meta_image ordering and update timestamp; default tax label/percentage applied when apply_tax is true.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

🐰 A tiny card image hops into view,
Numbers and GST tidy up the queue,
Fields lined up neat in JSON and Py,
I nibble bugs and let the tests fly 🥕✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The PR includes additional tax-related fields (apply_tax, tax_label, tax_percentage) and meta_image field that are not mentioned in issue #121, representing out-of-scope changes. Remove or isolate tax-related fields and meta_image additions into separate PRs if they are not part of issue #121's scope, or clarify their necessity in PR description.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the primary change: adding a card image field to the website tab of Buzz Event doctype.
Linked Issues check ✅ Passed The PR implements the core requirement from issue #121 by adding a new card_image field (Attach Image) to the Buzz Event doctype with proper configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.



📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 14125da and 63d50dd.

📒 Files selected for processing (1)
  • buzz/events/doctype/buzz_event/buzz_event.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Server
🔇 Additional comments (2)
buzz/events/doctype/buzz_event/buzz_event.json (2)

36-37: LGTM!

The field order correctly places both meta_image and card_image in the second column (after column_break_ndtl), addressing the reviewer's feedback to reduce empty space and improve layout.


369-373: LGTM!

The card_image field definition is consistent with other Attach Image fields in this DocType (e.g., meta_image, banner_image).

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@NagariaHussain
Copy link
Contributor

Please add a screenshot of the form.

@imgullu786
Copy link
Collaborator Author

Screenshot

Screenshot 2026-01-14 at 1 01 32 AM

@NagariaHussain
Copy link
Contributor

NagariaHussain commented Jan 14, 2026

Let's move both the image field to the 2nd column. Lots of empty space, does not look good.

@NagariaHussain NagariaHussain merged commit 44da7b3 into BuildWithHussain:main Jan 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a new card image field in Buzz event

2 participants