Skip to content

Conversation

@gabitoesmiapodo
Copy link
Collaborator

No description provided.

@vercel
Copy link

vercel bot commented Nov 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
cowswap Ready Ready Preview Comment Nov 4, 2025 2:34pm

@github-actions
Copy link

github-actions bot commented Nov 4, 2025


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates translation files to correct the handling of wallet type strings in order tooltips. The changes replace the translatable "Safe" string (which was incorrectly being translated) with "Smart contract" for non-Safe wallets, while keeping "Safe" as a brand name that should not be translated.

  • Adds "Smart contract" translation entry for Russian and Spanish locales
  • Marks previous "Safe" translations as obsolete and corrects them to use the brand name "Safe" instead of translated words
  • Updates revision dates in locale metadata

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
apps/cowswap-frontend/src/locales/en-US.po Removes "Smart contract" entry and restores "Safe" as active translation
apps/cowswap-frontend/src/locales/ru-RU.po Adds "Smart contract" entry (untranslated) and marks "Safe" as obsolete with corrected brand name
apps/cowswap-frontend/src/locales/es-ES.po Adds "Smart contract" entry (untranslated) and marks "Safe" as obsolete with corrected brand name

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 2598 to 2599
msgid "Safe"
msgstr "Safe"
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The en-US locale is restoring the 'Safe' translation as active while ru-RU and es-ES are marking it as obsolete. Based on the code at line 78 of OrderFillsAt/index.tsx (const walletType = isSafeWallet ? 'Safe' : t'Smart contract'), the 'Safe' string is hardcoded and not translated, so only 'Smart contract' should have a translation entry. The 'Safe' entry should remain obsolete in all locale files for consistency.

Copilot uses AI. Check for mistakes.

#: apps/cowswap-frontend/src/modules/ordersTable/pure/OrderFillsAt/index.tsx
msgid "Smart contract"
msgstr ""
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Russian translation for 'Smart contract' is missing. The msgstr should be populated with the Russian translation 'Смарт-контракт' to provide a complete localization experience.

Suggested change
msgstr ""
msgstr "Смарт-контракт"

Copilot uses AI. Check for mistakes.

#: apps/cowswap-frontend/src/modules/ordersTable/pure/OrderFillsAt/index.tsx
msgid "Smart contract"
msgstr ""
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Spanish translation for 'Smart contract' is missing. The msgstr should be populated with the Spanish translation 'Contrato inteligente' to provide a complete localization experience.

Suggested change
msgstr ""
msgstr "Contrato inteligente"

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@gabitoesmiapodo gabitoesmiapodo merged commit 796ccff into feat/internationalization-setup-for-swap-cow-fi Nov 4, 2025
4 of 7 checks passed
@gabitoesmiapodo gabitoesmiapodo deleted the l10n_feat/internationalization-setup-for-swap-cow-fi branch November 4, 2025 14:36
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants