-
Notifications
You must be signed in to change notification settings - Fork 1
New Crowdin updates #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Crowdin updates #72
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates translation files to correct the handling of wallet type strings in order tooltips. The changes replace the translatable "Safe" string (which was incorrectly being translated) with "Smart contract" for non-Safe wallets, while keeping "Safe" as a brand name that should not be translated.
- Adds "Smart contract" translation entry for Russian and Spanish locales
- Marks previous "Safe" translations as obsolete and corrects them to use the brand name "Safe" instead of translated words
- Updates revision dates in locale metadata
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| apps/cowswap-frontend/src/locales/en-US.po | Removes "Smart contract" entry and restores "Safe" as active translation |
| apps/cowswap-frontend/src/locales/ru-RU.po | Adds "Smart contract" entry (untranslated) and marks "Safe" as obsolete with corrected brand name |
| apps/cowswap-frontend/src/locales/es-ES.po | Adds "Smart contract" entry (untranslated) and marks "Safe" as obsolete with corrected brand name |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| msgid "Safe" | ||
| msgstr "Safe" |
Copilot
AI
Nov 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The en-US locale is restoring the 'Safe' translation as active while ru-RU and es-ES are marking it as obsolete. Based on the code at line 78 of OrderFillsAt/index.tsx (const walletType = isSafeWallet ? 'Safe' : t'Smart contract'), the 'Safe' string is hardcoded and not translated, so only 'Smart contract' should have a translation entry. The 'Safe' entry should remain obsolete in all locale files for consistency.
|
|
||
| #: apps/cowswap-frontend/src/modules/ordersTable/pure/OrderFillsAt/index.tsx | ||
| msgid "Smart contract" | ||
| msgstr "" |
Copilot
AI
Nov 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Russian translation for 'Smart contract' is missing. The msgstr should be populated with the Russian translation 'Смарт-контракт' to provide a complete localization experience.
| msgstr "" | |
| msgstr "Смарт-контракт" |
|
|
||
| #: apps/cowswap-frontend/src/modules/ordersTable/pure/OrderFillsAt/index.tsx | ||
| msgid "Smart contract" | ||
| msgstr "" |
Copilot
AI
Nov 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Spanish translation for 'Smart contract' is missing. The msgstr should be populated with the Spanish translation 'Contrato inteligente' to provide a complete localization experience.
| msgstr "" | |
| msgstr "Contrato inteligente" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
796ccff
into
feat/internationalization-setup-for-swap-cow-fi
No description provided.