Skip to content

Conversation

@limpbrains
Copy link
Collaborator

No description provided.

@limpbrains limpbrains marked this pull request as ready for review January 1, 2026 12:20
@limpbrains
Copy link
Collaborator Author

Please test on a real device guys

@ojokne
Copy link
Member

ojokne commented Jan 1, 2026

Please test on a real device guys

I have tested on Samsung A54

Tested the following

  • scanning QR code to get address to send to
  • scanning QR code to add LND node
  • Scanning QR code to import a wallet and watch only wallet

These all worked as expected, no issues detected

Yet to test scanning signed psbt (dont have my hardware wallet currently)

@limpbrains
Copy link
Collaborator Author

I'm curious how good is it with unusual qrcodes, like https://qrcode.reactiive.io

@ojokne
Copy link
Member

ojokne commented Jan 1, 2026

I'm curious how good is it with unusual qrcodes, like https://qrcode.reactiive.io

When I was testing the paulmillr/qr package, it could not decode qr codes in eci format.

Below is the error I was getting
Error decoding QR code: Error: Unknown mode=eci

This doesnt also seem to scan them

@limpbrains
Copy link
Collaborator Author

limpbrains commented Jan 1, 2026

I've tested it with all wallet apps I have on my phone
A few qrcodes didn't work here they are:

Copay:

Metamask:
This one doesn't work with dark theme, if I switch to light and QR code has white background, it works

Rainbow wallet:

So I guess we need to think a bit more if it is actually worth it

@Overtorment
Copy link
Member

just downloaded apk, gona test with a bunch of hw wallets

@Overtorment
Copy link
Member

looks like the binary lost 10 mb because of mlkit is no longer shipped!
HUGE win.

image

@GladosBlueWallet
Copy link
Collaborator

Wake the fuck up samurai, we have PRs to merge

image

[all PRs for @ojokne] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/ojokne

@GladosBlueWallet
Copy link
Collaborator

Wake the fuck up samurai, we have PRs to merge

image

[all PRs for @marcosrdz] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/marcosrdz

@Overtorment
Copy link
Member

i tested on a bunch of qrs, the one that matter: bw qr codes, other walelts qr codes, bbqr, like 6 different hardware wallets. all works. its the weird ones from rainbow wallet do not work
and its potentially fixable in the future

@Overtorment Overtorment merged commit 588315e into master Jan 7, 2026
13 checks passed
@Overtorment Overtorment deleted the nogoogle branch January 7, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants