curve/torque bar for configured curature based cars #40
Conversation
jchristman75
force-pushed
the
bp-c4-torque-o-meter
branch
from
e1545c7 to
f4b1ef0
Compare
jchristman75
changed the title
jchristman75
force-pushed
the
bp-c4-torque-o-meter
branch
from
3266c17 to
094341b
Compare
blue-genie
left a comment
blue-genie
left a comment
There was a problem hiding this comment.
I provided a few comments, none of them are really critical just for future proofing and maintain compatibility for other cars.
Since I don't really know the full scope of this project I will let @alan-polk comment if these comments are applicable for this PR or not.
|
|
||
| if ui_state.sm['controlsState'].lateralControlState.which() != 'angleState': | ||
| self._torque_bar.render(rect) | ||
| self._torque_bar.render(rect) |
There was a problem hiding this comment.
I think it's safer to keep the if statement but add a an or for fords, or only if lateralUncertainty is available or something that would ensure that you don't break the functionality for other cars. We have users with Fords and Hyundai.
|
Thank you so much for taking the time to review my PR. This type of insight, especially in the nuance of Cereal are very helpful. I will repair these deficiencies, hopefully later tonight. Thank you, |
jchristman75
force-pushed
the
bp-c4-torque-o-meter
branch
from
351521a to
6bfe6f7
Compare
3 participants
Description
Enable the torque bar for curvature based cars; starting with Ford.