Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Conversation

@ilkilic
Copy link
Collaborator

@ilkilic ilkilic commented Dec 3, 2024

Add script for generating the mapping data between met-types and ion channels. Also update README, citations and author list order

@ilkilic ilkilic requested a review from darshanmandge December 3, 2024 13:07
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 164 lines in your changes missing coverage. Please review.

Project coverage is 51.27%. Comparing base (8d5b0ab) to head (2866ca8).
Report is 130 commits behind head on main.

Files with missing lines Patch % Lines
...emodel/icselector/met_type_ic_profile_generator.py 0.00% 164 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
- Coverage   60.07%   51.27%   -8.81%     
==========================================
  Files         109      125      +16     
  Lines        7838    10733    +2895     
==========================================
+ Hits         4709     5503     +794     
- Misses       3129     5230    +2101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darshanmandge
Copy link
Collaborator

Could you also fix this minor typo in the L5PC example README:
"morph_modifiers";["replace_axon_with_taper"] to "morph_modifiers":["replace_axon_with_taper"]
here (thanks for Matus Tomko for pointing this out).

@ilkilic
Copy link
Collaborator Author

ilkilic commented Dec 9, 2024

good catch! fixed in the last commit

@ilkilic ilkilic merged commit dccd16d into main Dec 9, 2024
6 checks passed
@ilkilic ilkilic deleted the ion-channel-selector branch December 9, 2024 10:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants