Refactor filesPage.py: Changed Files List QtWidgets.QListWidgetItem to our custom EntryListModel
#126
+165
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 11, 2025 17:32
…itemclick helper_methods: updated the get_file_loc method to return always the filename instead of the full path Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
…file_name Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
…g commented lines Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
gmmcosta15
added
the
Refactor
Signed-off-by: gmmcosta15 <guilherme.costa@blockstec.com>
gmmcosta15
changed the title
filesPage.py changed QtWidgets.QListWidgetItem to our custom EntryListModelfilesPage.py: Changed Files ListQtWidgets.QListWidgetItem to our custom EntryListModel
gmmcosta15
changed the title
filesPage.py: Changed Files ListQtWidgets.QListWidgetItem to our custom EntryListModelfilesPage.py: Changed Files List QtWidgets.QListWidgetItem to our custom EntryListModel
HugoCLSC
reviewed
Dec 15, 2025
Member
HugoCLSC
left a comment
HugoCLSC
left a comment
There was a problem hiding this comment.
Everything looks good, only two remarks :
- Some method docstrings were deleted due to a previous rebase/merge
- The files list is not centered on the page, it's currently shifted to the left.
Just fix these two things and it will be accepted
| logger.debug("Item Selected") | ||
|
|
||
| @QtCore.pyqtSlot(name="reset-dir") | ||
| def reset_dir(self) -> None: |
| self.curr_dir = "" | ||
| self.request_dir_info[str].emit(self.curr_dir) | ||
|
|
||
| def showEvent(self, a0: QtGui.QShowEvent) -> None: |
| return super().showEvent(a0) | ||
|
|
||
| @QtCore.pyqtSlot(list, name="on-file-list") | ||
| def on_file_list(self, file_list: list) -> None: |
| # self._build_file_list() | ||
|
|
||
| @QtCore.pyqtSlot(list, name="on-dirs") | ||
| def on_directories(self, directories_data: list) -> None: |
Set file list to refresh after 1.5s to improve UI responsiveness. Clicks are now handled in the _on_item_selected slot instead of inline callbacks to separate logic and unify behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
helper_methods.pyCreated method
get_file_namethat accepts a string with the filepath and returns only the filenamelib/panels/widget/filesPage.pyChanged implementation of how the files are showed, from a ´QtWidgets.QListWidgetItem´ to our custom
EntryListModelScreenshots
Future Work
on_delete_fileSlot