Turn match() into a generic for specialization by other BiocPy classes. #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a create_match_index generic that builds the matching index from a given 'targets' so that it can be easily reused across different 'x'. An example of a compatible index is provided by the new MatchIndex class. Also added dedicated optimization for Factor matching, which exploits the fact that unique levels are already available.
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #38 +/- ##
==========================================
- Coverage 90.80% 90.74% -0.06%
==========================================
Files 42 42
Lines 1783 1837 +54
Branches 358 377 +19
==========================================
+ Hits 1619 1667 +48
- Misses 113 116 +3
- Partials 51 54 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
This avoids hard-coding None and numpy.ma.masked as unmatchable elements. The default is an empty set, which means that None values can now be matched; this is more consistent with the default behavior of R's match().
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a create_match_index generic that builds the matching index from a given 'targets' so that it can be easily reused across different 'x'. An example of a compatible index is provided by the new MatchIndex class.
Also added dedicated optimization for Factor matching, which exploits the fact that unique levels are already available.