Fix patches and escape #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the removal and clearing of _highlighted_bin_patches from Histogram2D._highlight_data to the base Artist class cleanup methods. This fixes a bug where patches were being cleared multiple times and the list of patches was not being emptied.
Adds a showEvent handler to CanvasWidget to re-bind the Escape key to clear selections and highlights when the widget is shown.
Ensures that highlighted bin patches are shown or hidden when the artist's visibility is changed by updating their visibility state accordingly.
Update the package version from 0.4.0 to 0.4.1 in preparation for a new release.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 81.24% 81.47% +0.22%
==========================================
Files 9 9
Lines 1386 1387 +1
==========================================
+ Hits 1126 1130 +4
+ Misses 260 257 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves bugs described in #71, #72 and #73 .