0.8.0 - Priority#to_f, plus some regression coverage
#54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Delayed::Job.enqueue ErrorJob.new | ||
| described_class.new.work_off | ||
|
|
||
| expect(events).to eq %i(thread_start perform_start perform_end thread_end) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding regression coverage for the changes made in #53, and making one additional change in line with the way that the
:performcallback works in thedelayed_jobgem - there is also now a test that will more explicitly check the order of callback events and behavior on job failure.Plus, while debugging in an app, I noticed that datadog tries to cast priority to a float, which was raising a method undefined error. So I added
Delayed::Priority#to_fand added a test to cover all the explicit conversion methods (to_s,to_i,to_f,to_d)./no-platform