Skip to content

Conversation

@Aholicknight
Copy link

This pull request includes changes to enhance the user experience. The new change includes adding a user confirmation dialog to keep plugins enabled and ensuring consistent logging and progress updates.

electron_20250216_8C5YAtDVdU

User experience improvements:

  • Added a confirmation dialog in the disableAllPlugins function to ask users if they want to keep their plugins enabled. If the user chooses to keep the plugins enabled, the deletion of plugins.json is skipped.

@KingGamingYT
Copy link

Correct me if I’m wrong, but is this not just what the install option does but with an extra confirmation prompt?

@Aholicknight
Copy link
Author

Aholicknight commented Feb 14, 2025

Correct me if I’m wrong, but is this not just what the install option does but with an extra confirmation prompt?

@KingGamingYT No. When you repair betterdiscord, all plugins are disabled. For some users, this can be tiresome enabling plugins one by one, if you have tons.

@zerebos
Copy link
Member

zerebos commented Feb 14, 2025

The repair option's only feature above install is disabling plugins. For users that just need to reinstall after an update, they should use install not repair.

@Aholicknight
Copy link
Author

The repair option's only feature above install is disabling plugins. For users that just need to reinstall after an update, they should use install not repair.

@zerebos I thought if you chose install instead of repair, it will wipe out all the installed plugins and themes?

@Aholicknight Aholicknight changed the title prompt user to confirm keeping plugins enabled before deletion prompt user to keep plugins when repairing Feb 14, 2025
@KingGamingYT
Copy link

KingGamingYT commented Feb 14, 2025

I thought if you chose install instead of repair, it will wipe out all the installed plugins and themes?

Install simply re-installs BetterDiscord's files and re-injects it into the client. No plugins or themes are touched.

@Aholicknight
Copy link
Author

Install simply re-installs BetterDiscord's files and re-injects it into the client. No plugins or themes are touched.

@KingGamingYT If install re-installs BetterDiscord's files, then why is there a repair option?

@9thyear2
Copy link

@Aholicknight i have a separate question. why are we trying to improve the electron version when there is a push to move to wails...

#381

i feel like efforts would be better spent working and improving the UI on the next version that's under development, or maybe working on this particular checkbox which that same pull request covers (even though its a further out goal, that doesn't mean someone else can't work on it)

Screenshot_20250831_152517_mod_with_arrow

in all honesty, if your pull request gets merged. it will just ultimately be deprecated. when they move to wails. especially since all the development that's happened to the installer in the past 2 years have been on the wails branch (at least on github)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants