Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 10, 2026

Description

Checkstyle 13.0.0 introduced stricter SummaryJavadoc validation requiring class-level JavaDoc summaries to begin with a verb or proper noun. Four Jackson module classes had summaries starting with "xAPI" (lowercase 'x'), triggering violations.

Changes

  • Updated checkstyle dependency to 13.0.0
  • Revised JavaDoc summaries in Jackson modules to start with "Provides" verb:
    • XapiStrictNullValuesModule
    • XapiStrictTimestampModule
    • XapiStrictObjectTypeModule
    • XapiStrictLocaleModule

Checklist:

  • Public methods are documented
  • Public methods are tested
  • New and existing tests pass when run locally
  • There are no new warnings or errors

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 10, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • checkstyle.org
    • Triggering command: /opt/hostedtoolcache/CodeQL/2.23.8/x64/codeql/tools/linux64/java/bin/java /opt/hostedtoolcache/CodeQL/2.23.8/x64/codeql/tools/linux64/java/bin/java -jar /opt/hostedtoolcache/CodeQL/2.23.8/x64/codeql/xml/tools/xml-extractor.jar --fileList=/home/REDACTED/work/xapi-java/.codeql-scratch/dbs/java/working/files-to-index9654946410624213982.list --sourceArchiveDir=/home/REDACTED/work/xapi-java/.codeql-scratch/dbs/java/src --outputDir=/home/REDACTED/work/xapi-java/.codeql-scratch/dbs/java/trap/java (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update checkstyle from version 12.3.0 to 13.0.0 Bump com.puppycrawl.tools:checkstyle from 12.3.0 to 13.0.0 Jan 10, 2026
Copilot AI requested a review from thomasturrell January 10, 2026 22:40
@thomasturrell thomasturrell marked this pull request as ready for review January 10, 2026 23:04
@thomasturrell thomasturrell merged commit 4263af3 into dependabot/maven/com.puppycrawl.tools-checkstyle-13.0.0 Jan 10, 2026
@thomasturrell thomasturrell deleted the copilot/sub-pr-468 branch January 10, 2026 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants