Closes #4570: Simplify and extend logic in doBigIntBinOpvs and doBigIntBinOpvsBoolReturn #5227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1RyanK
force-pushed
the
4570-simplify_and_extend_logic_in_dobigintbinopvs_and_dobigintbinopvsboolreturn
branch
from
c45fb67 to
06f4c48
Compare
… I don't think I will end up writing super complete ones, but I'll revisit these files later and clean them up better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wraps together the remainder of refactoring
BinOp.chplandOperatorMsg.chpl. That includes theopeqvvfunction and theopeqvsfunction, which I never created issues for but we're just bundling it in here.Closes #4570: Simplify and extend logic in doBigIntBinOpvs and doBigIntBinOpvsBoolReturn
Closes #4571: Simplify and extend logic in doBigIntBinOpsv and doBigIntBinOpsvBoolReturn
Closes #4448: Simplify and extend logic in binop functions