-
Notifications
You must be signed in to change notification settings - Fork 97
Closes #5105: ArkoudaExtensionArray.__getitem__ #5106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ajpotts
wants to merge
4
commits into
Bears-R-Us:main
Choose a base branch
from
ajpotts:5105_ArkoudaExtensionArray_getitem
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Closes #5105: ArkoudaExtensionArray.__getitem__ #5106
ajpotts
wants to merge
4
commits into
Bears-R-Us:main
from
ajpotts:5105_ArkoudaExtensionArray_getitem
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4ed7c8b to
27a4bef
Compare
1RyanK
approved these changes
Dec 12, 2025
Collaborator
1RyanK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
27a4bef to
78de756
Compare
7e7c2f3 to
8fabbbb
Compare
8fabbbb to
b50789d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5106 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 4
Lines ? 63
Branches ? 0
========================================
Hits ? 63
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b50789d to
a20ae1f
Compare
75aade4 to
7d55305
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: Unified Indexing & Assignment for Arkouda Extension Arrays
This PR introduces a complete overhaul of
__getitem__and__setitem__across all Arkouda-backed pandas ExtensionArray types:ArkoudaArrayArkoudaStringArrayArkoudaCategoricalArrayThe goal is to bring these classes into full alignment with pandas/NumPy indexing rules, while ensuring all operations are executed entirely on the Arkouda server (no unintended materialization, no
to_numpy()orto_ndarray()inside assignment paths).Summary of Changes
⭐ 1. Unified Indexer Normalization
All extension arrays now normalize Python / NumPy indexers the same way:
int,slice: forwarded directly to the underlying Arkouda objectak.array(..., dtype=int64/uint64)ak.array(..., dtype=bool)ak.array(...)pdarrayindexers pass through unchanged[],np.array([], ...)) return an empty array of the same typeThis ensures consistency across array types and avoids breaking pandas’ internal indexing machinery.
⭐ 2. New
__getitem__ImplementationsArkoudaArrayArkoudaArrayfor everything else.ExtensionArray.__getitem__type signature.ArkoudaStringArrayobjectdtype arrays when round-tripped through NumPy.ArkoudaCategoricalArraystr_.Closes #5105: ArkoudaExtensionArray.getitem