Skip to content

filter out in progress closest convos for sync #3863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mdmohsin7 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −0
Draft

filter out in progress closest convos for sync #3863

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions backend/database/conversations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -958,6 +958,7 @@ def get_closest_conversation_to_timestamps(uid: str, start_timestamp: int, end_t
db.collection('users')
.document(uid)
.collection(conversations_collection)
.where(filter=FieldFilter('status', '==', ConversationStatus.completed))
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

While filtering by status is correct, the overall query is invalid and will cause a runtime error due to Firestore limitations. Specifically:

  1. The query uses range filters on two different fields (finished_at on line 962 and started_at on line 963), which is not allowed. A Firestore query can only have range filters on a single field.
  2. The query uses range filters, but the first order_by clause is on a different field (created_at on line 964). If a range filter is present, the first order_by must be on the same field as the range filter.

This query needs to be refactored. A possible solution is to use only one range filter in the query (e.g., on started_at) and then filter the remaining conditions (e.g., finished_at) in memory on the client side.

.where(filter=FieldFilter('finished_at', '>=', start_threshold))
.where(filter=FieldFilter('started_at', '<=', end_threshold))
.order_by('created_at', direction=firestore.Query.DESCENDING)
Expand Down