Multiple New Features, and data structure rework #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
March 7, 2022 14:42
…e where module is unable to display destination data on form; Fix issue with moving data between a classic and longitudinal project
Fixed incorrect equals operator
Adding functionality to save a survey url from the destination project to the source project.
Fixed error with checking the wrong project when validating which field to save survey url to. Also made field optional.
Fixed issue with autocomplete for selecting an instrument to generate a survey on, where the autocomplete would populate with instruments from the source project.
Fix bug with autocomplete for survey generation not updating on project change.
Updated logging statement, deleted line of code to clear form item.
Updated module to use event id when generating survey url
Added condition that survey generation will only run if fields are filled.
Made event input for survey generation optional
Added checks to form validation for survey url generation.
Updated form text.
Changed incorrect assignment operator
Added HTML and Jquery for adding prefixes and postfixes to source linking field.
Implemented adding a prefix or postfix to linking IDs in the backend.
Fixed "else if" statement
Changed JQuery attr function to prop
Moved checked attribute for setting value of prefix/postfix checkbox
Fixed error with appending prefix to linking ID.
Updated HTML text
Removed a reference to "event_1_arm_1"; Made HTML change
Fixed issue with determining which event to move data into when transferring whole instruments between two classic projects.
Updated code to handle format switch for projects that saved JSON using old format.
Changes to pass PSALM Taint analysis
Added filtering for fields that don't exist in the destination project, when moving whole instruments. Updated composer files.
Added extra check in case all fields filtered out when moving whole instruments
Updated modal for JSON export
Added extra check to see if $settings is set and not null.
Added new function to provide simple validation for JSON containing det settings
Updated conditions to check existing settings
Added basic checking for proper json structure
Added missing bracket
Added more logging statements
Added name space for index.php
Fixed issue where logs incorrectly suggested there was invalid JSON, when "det_settings" was in fact null (no DET exists)
Added one more condition to check whether settings exist in the project
Added [redcap_data_access_group] as field under Data Movement that can be set as any other field
Make any import of [redcap_data_access_group] lowercase, updated UI
Update functionality to move DAGs to accept the unique group id, rather than the group name
Updated text to move DAGs conditionally between project
Fixed issue where table row would not populate manual value if it was 0.
Updated code to allow the transfer of non-repeat instruments on a project with repeating instruments/events enabled
Doubled the limit for number of allowed triggers
Updated alert for when maximum amount of triggers are met
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
We've made some extensive changes to the em that we thought would be useful to push. The em can now do the following:
I've updated the instructions in the README.md, but the most important thing about these changes is that they change they way the JSON object which contains the DET settings is stored. This means that once you install the new version, you'll have to manually enter all your existing DET settings again.
Some of these changes have also been inspired by an unreleased em from Stanford. I've been in contact with them about providing acknowledgements, but haven't received a definite reply, so please only use the changes internally for now.