Skip to content

Conversation

@howieleung
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@howieleung howieleung enabled auto-merge (squash) December 8, 2025 22:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a runtime solution for handling CRLF to LF line ending conversions in test files, replacing the previous .gitattributes-based approach. The change ensures consistent binary representation of test assets across Windows and Linux platforms during test execution.

Key Changes:

  • Adds a patched open() function that automatically converts CRLF to LF for text files opened in binary read mode
  • Removes .gitattributes file that previously enforced LF line endings at the git level
  • Updates test assets tag to reflect the new approach

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
sdk/ai/azure-ai-projects/tests/samples/test_samples.py Implements ConvertedFileWrapper class and _patched_open() method to handle CRLF-to-LF conversion at runtime
sdk/ai/azure-ai-projects/samples/agents/assets/.gitattributes Removes git-level line ending enforcement for test assets
sdk/ai/azure-ai-projects/assets.json Updates assets repository tag

@howieleung howieleung force-pushed the howie/sample-recording-4 branch from 05da95c to bd42f93 Compare December 9, 2025 04:11
@howieleung howieleung changed the title path open function to convert crlf to lf patch open function to convert crlf to lf Dec 9, 2025
@howieleung howieleung disabled auto-merge December 9, 2025 07:36
@howieleung howieleung enabled auto-merge (squash) December 9, 2025 07:37
@howieleung howieleung merged commit 2d076c3 into main Dec 9, 2025
20 checks passed
@howieleung howieleung deleted the howie/sample-recording-4 branch December 9, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants